[PATCH] D20770: [GSoC 2016][Polly][Refactor] Decouple SCoP building logic from pass

Utpal Bora via llvm-commits llvm-commits at lists.llvm.org
Mon May 30 06:04:17 PDT 2016


cs14mtech11017 added inline comments.

================
Comment at: include/polly/ScopInfo.h:2250
@@ -2249,3 +2249,3 @@
 /// @brief Build the Polly IR (Scop and ScopStmt) on a Region.
-class ScopInfo : public RegionPass {
   //===-------------------------------------------------------------------===//
----------------
grosser wrote:
> Would it make sense to call this ScopBuilder? This seems more descriptive.
> 
> You can probably do this in a follow-up commit.
I was in the intuition of making least possible changes to the existing code base.
Please suggest changes that you feel will be better in general.

If I am not wrong, we do not need to change the files names of ScopInfo.h and ScopInfo.cpp right? Changing only class name is makes sense.


http://reviews.llvm.org/D20770





More information about the llvm-commits mailing list