[PATCH] D11798: [mips][microMIPS] Implement BOVC, BNVC, EXT, INS and JALRC instructions

Hrvoje Varga via llvm-commits llvm-commits at lists.llvm.org
Mon May 30 02:28:30 PDT 2016


hvarga added inline comments.

================
Comment at: lib/Target/Mips/MicroMipsInstrInfo.td:891
@@ -891,1 +890,3 @@
+  def JR_MM : MMRel, IndirectBranch<"jr", GPR32Opnd>, JR_FM_MM<0x3c>,
+              ISA_MICROMIPS32_NOT_MIPS32R6;
   def JALR_MM : JumpLinkReg<"jalr", GPR32Opnd>, JALR_FM_MM<0x03c>;
----------------
I think that `hasMips64r6()` is redundant since predicates are cumulative. So I think it is ok to leave this as is. Do you agree?


http://reviews.llvm.org/D11798





More information about the llvm-commits mailing list