[llvm] r271146 - [COFFDumper] Make sure there is sufficient padding left in the string table

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Sat May 28 13:04:48 PDT 2016


Author: majnemer
Date: Sat May 28 15:04:48 2016
New Revision: 271146

URL: http://llvm.org/viewvc/llvm-project?rev=271146&view=rev
Log:
[COFFDumper] Make sure there is sufficient padding left in the string table

Modified:
    llvm/trunk/tools/llvm-readobj/COFFDumper.cpp

Modified: llvm/trunk/tools/llvm-readobj/COFFDumper.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp?rev=271146&r1=271145&r2=271146&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-readobj/COFFDumper.cpp (original)
+++ llvm/trunk/tools/llvm-readobj/COFFDumper.cpp Sat May 28 15:04:48 2016
@@ -687,7 +687,10 @@ void COFFDumper::initializeFileAndString
     default:
       break;
     }
-    Data = Data.drop_front(alignTo(SubSectionSize, 4));
+    uint32_t PaddedSize = alignTo(SubSectionSize, 4);
+    if (PaddedSize > Data.size())
+      error(object_error::parse_failed);
+    Data = Data.drop_front(PaddedSize);
   }
 }
 




More information about the llvm-commits mailing list