[PATCH] D20735: [Support] Allow nesting paired calls to {start, stop}Timer

[Sean Silva via llvm-commits]

On Fri, May 27, 2016 at 10:11 AM, Rafael Espíndola <
llvm-commits at lists.llvm.org> wrote:

> It seems pretty odd to have a timer that can be started multiple times. If
> we can avoid it I think we should.
>

+1

-- Sean Silva

> Cheers,
> Rafael
> On May 27, 2016 1:05 PM, "Davide Italiano" <dccitaliano at gmail.com> wrote:
>
>> davide added a comment.
>>
>> In http://reviews.llvm.org/D20735#442381, @rafael wrote:
>>
>> > How hard would it be to change the callers that currently depend on
>> this?
>>
>>
>> I have a patch that changes the clang timer where I hit this issue. I'm
>> going to put it up for review.
>> The real worry on my side is that I'm not aware of all the possible cases
>> where we rely on this behavior.
>> We can just drop Vedant's patch on the floor, and wait until we hit the
>> assertions, and fix the bugs as they show up.
>> What's your opinion?
>>
>>
>> http://reviews.llvm.org/D20735
>>
>>
>>
>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160527/9fdf2714/attachment.html>