[PATCH] D20739: Better fix for PR27903.

Wei Mi via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 13:22:33 PDT 2016


wmi added inline comments.

================
Comment at: lib/CodeGen/StackColoring.cpp:563
@@ +562,3 @@
+  for (unsigned slot = 0; slot < NumSlot; ++slot)
+    if (NumStartLifetimes[slot] > 1)
+      ConservativeSlots.set(slot);
----------------
It may be a stupid question. I am wondering is it possible for one slot to have one Lifetime_start and two Livetime_end? Could it be more safe to use NumEndLifetimes[] > 1 as the condition to fall back?


http://reviews.llvm.org/D20739





More information about the llvm-commits mailing list