[PATCH] D20724: [pdb] Apply zero-copy algorithms to symbol stream iteration

[Rui Ueyama via llvm-commits]

ruiu added a comment.

OK, I wouldn't make a trait class at this moment as it has already lots of meta programming, but it's your call.


================
Comment at: include/llvm/DebugInfo/CodeView/RecordIterator.h:41-44
@@ +40,6 @@
+    Item.Type = static_cast<Kind>(uint16_t(Prefix->RecordKind));
+    if (auto EC = Reader.readBytes(Item.Length - 2, Item.Data)) {
+      consumeError(std::move(EC));
+      return 0;
+    }
+    return Prefix->RecordLen + 2;
----------------
Don't you want to propagate the error up to the caller? Hiding errors in a deep function call seems risky.


http://reviews.llvm.org/D20724