[PATCH] D20731: Disable lifetime-start-on-first-use analysis.

[Teresa Johnson via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

Couple of minor comments, otherwise LGTM. Thanks!


================
Comment at: lib/CodeGen/StackColoring.cpp:78
@@ -77,3 +77,3 @@
 /// for LIFETIME_START marker). See "Implementation notes" below for
-/// more info.
+/// more info. NB: set to false for the moment due to Bug 27903.
 static cl::opt<bool>
----------------
LLVM tends to use "PR27903" when referring to bug ids. Also "FIXME" instead of "NB"

================
Comment at: test/CodeGen/X86/StackColoring.ll:549
@@ +548,3 @@
+;CHECK-LABEL: twobod_b27903:
+;FIRSTUSE: subq  $56, %rsp
+;YESCOLOR: subq  $96, %rsp
----------------
If this test case is exposing the bug, probably a FIXME with the expected output once this is corrected would be good.


http://reviews.llvm.org/D20731