[PATCH] D20724: [pdb] Apply zero-copy algorithms to symbol stream iteration

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri May 27 07:50:06 PDT 2016


ruiu added inline comments.

================
Comment at: include/llvm/DebugInfo/CodeView/RecordIterator.h:29
@@ +28,3 @@
+
+template <typename Kind> struct CVRecordTraits {
+  typedef CVRecord<Kind> ValueType;
----------------
Do you need a separate traits class? Looks like you can merge it into the non-traits class if you change the definition of VarStreamArray.


http://reviews.llvm.org/D20724





More information about the llvm-commits mailing list