[PATCH] D20719: Remove use of is_trivially_constructible.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 19:53:03 PDT 2016


ruiu added inline comments.

================
Comment at: include/llvm/DebugInfo/CodeView/StreamArray.h:114-115
@@ -113,4 +113,2 @@
   friend class FixedStreamArrayIterator<T>;
-  static_assert(std::is_trivially_constructible<T>::value,
-                "FixedStreamArray must be used with trivial types");
 
----------------
majnemer wrote:
> You could go with `std::is_standard_layout<T>::value && std::is_trivial<T>::value` to get more or less the same thing.
This seems a bit too tricky to me. It would just fail if you pass non-trivially-constructible class to this one, so I'm okay without this assertion.


http://reviews.llvm.org/D20719





More information about the llvm-commits mailing list