[PATCH] D20656: [MC] Use obj output for .fill tests where needed
Rafael EspĂndola via llvm-commits
llvm-commits at lists.llvm.org
Thu May 26 18:21:48 PDT 2016
LGTM
On 26 May 2016 at 16:12, Petr Hosek <phosek at chromium.org> wrote:
> phosek retitled this revision from "[MC] Remove the leftover warning check" to "[MC] Use obj output for .fill tests where needed".
> phosek updated the summary for this revision.
> phosek updated this revision to Diff 58678.
> phosek added a comment.
>
> That's a better solution.
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D20656
>
> Files:
> test/MC/AsmParser/directive_fill.s
>
> Index: test/MC/AsmParser/directive_fill.s
> ===================================================================
> --- test/MC/AsmParser/directive_fill.s
> +++ test/MC/AsmParser/directive_fill.s
> @@ -1,5 +1,7 @@
> # RUN: llvm-mc -triple i386-unknown-unknown %s 2> %t.err | FileCheck %s
> # RUN: FileCheck --check-prefix=CHECK-WARNINGS %s < %t.err
> +# RUN: llvm-mc -triple i386-unknown-unknown -filetype=obj -o %t.o %s 2> %t.err
> +# RUN: FileCheck --check-prefix=OBJ-WARNINGS %s < %t.err
>
> # CHECK: TEST0:
> # CHECK: .fill 1, 1, 0xa
> @@ -43,7 +45,9 @@
> TEST7:
> .fill 1, 8, 1<<32
>
> -# CHECK-WARNINGS: '.fill' directive with negative repeat count has no effect
> +# CHECK: TEST8
> +# CHECK: .fill -1, 8, 0x1
> +# OBJ-WARNINGS: '.fill' directive with negative repeat count has no effect
> TEST8:
> .fill -1, 8, 1
>
> @@ -56,10 +60,13 @@
> TEST10:
> .fill 1, 3, 0x12345678
>
> +# CHECK: TEST11
> # CHECK: .fill TEST11-TEST10, 1, 0x0
> TEST11:
> .fill TEST11 - TEST10
>
> +# CHECK: TEST12
> # CHECK: .fill TEST11-TEST12, 3, 0x12345678
> +# OBJ-WARNINGS: '.fill' directive with negative repeat count has no effect
> TEST12:
> .fill TEST11 - TEST12, 3, 0x12345678
>
>
More information about the llvm-commits
mailing list