[llvm] r270865 - Use new interface in Triple /NFC

[Xinliang David Li via llvm-commits]

On Thu, May 26, 2016 at 5:05 PM, David Blaikie <dblaikie at gmail.com> wrote:

>
>
> On Thu, May 26, 2016 at 3:54 PM, Xinliang David Li <davidxl at google.com>
> wrote:
>
>> Mystery solved. The failure was caused by another silly mistake --
>> missing test case changes in one commit.
>>
>
> Just another commit that got bundled with this one in the same buildbot
> run?
>

looks like so.  To prevent misguessing similar failure in the future, I
have prepared a patch to allow FileCheck to dump more info with such errors.


>
>
>> About this change, what additional test do you recommend?
>>
>
> If this is actually not changing any observable behavior - no test
> required or possible.
>

That is what I thought. Just check to see if there is something else in
your mind.

thanks,

David

>
> - Dave
>
>
>>
>> David
>>
>> On Thu, May 26, 2016 at 10:56 AM, Xinliang David Li <davidxl at google.com>
>> wrote:
>>
>>> The failed test case is the one  that actually covers this part of the
>>> code (there is also another one for darwin at LLVM side which does not
>>> fail) - so it does not look like it is due to random flakiness. Both bots
>>> are PPC (one LE and one BE).
>>>
>>> David
>>>
>>> On Thu, May 26, 2016 at 10:50 AM, David Blaikie <dblaikie at gmail.com>
>>> wrote:
>>>
>>>> Nope - no idea, I haven't looked at it closely at all - just figured
>>>> since it broke a buildbot (I assume you diagnosed that correctly - but do
>>>> realize that many buildbots are flakey/complicated... so it may not be your
>>>> fault if you're pretty sure this is No Functional Change)
>>>>
>>>> On Thu, May 26, 2016 at 10:49 AM, Xinliang David Li <davidxl at google.com
>>>> > wrote:
>>>>
>>>>> I am a little puzzled why this change can make any change in compiler
>>>>> behavior. Any idea?
>>>>>
>>>>> David
>>>>>
>>>>> On Thu, May 26, 2016 at 10:38 AM, David Blaikie <dblaikie at gmail.com>
>>>>> wrote:
>>>>>
>>>>>> (I see this was reverted - but when it goes back it it could use a
>>>>>> test case)
>>>>>>
>>>>>> On Thu, May 26, 2016 at 9:28 AM, Xinliang David Li via llvm-commits <
>>>>>> llvm-commits at lists.llvm.org> wrote:
>>>>>>
>>>>>>> Author: davidxl
>>>>>>> Date: Thu May 26 11:28:01 2016
>>>>>>> New Revision: 270865
>>>>>>>
>>>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=270865&view=rev
>>>>>>> Log:
>>>>>>> Use new interface in Triple /NFC
>>>>>>>
>>>>>>> Modified:
>>>>>>>     llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
>>>>>>>
>>>>>>> Modified:
>>>>>>> llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
>>>>>>> URL:
>>>>>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp?rev=270865&r1=270864&r2=270865&view=diff
>>>>>>>
>>>>>>> ==============================================================================
>>>>>>> --- llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
>>>>>>> (original)
>>>>>>> +++ llvm/trunk/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
>>>>>>> Thu May 26 11:28:01 2016
>>>>>>> @@ -790,7 +790,7 @@ static void createIRLevelProfileFlagVari
>>>>>>>        INSTR_PROF_QUOTE(IR_LEVEL_PROF_VERSION_VAR));
>>>>>>>
>>>>>>>  IRLevelVersionVariable->setVisibility(GlobalValue::DefaultVisibility);
>>>>>>>    Triple TT(M.getTargetTriple());
>>>>>>> -  if (TT.isOSBinFormatMachO())
>>>>>>> +  if (!TT.supportsCOMDAT())
>>>>>>>      IRLevelVersionVariable->setLinkage(GlobalValue::WeakAnyLinkage);
>>>>>>>    else
>>>>>>>      IRLevelVersionVariable->setComdat(M.getOrInsertComdat(
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> llvm-commits mailing list
>>>>>>> llvm-commits at lists.llvm.org
>>>>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160526/3d80bd44/attachment.html>