[PATCH] D20654: [pdb] Try super hard to conserve memory in llvm-pdbdump

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 17:44:21 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/DebugInfo/PDB/Raw/MappedBlockStream.cpp:63
@@ +62,3 @@
+
+bool MappedBlockStream::tryReadContiguously(uint32_t Offset, uint32_t Size,
+                                            ArrayRef<uint8_t> &Buffer) const {
----------------
Please write a comment for this function that the function is to try to read contents if they are contiguous in file.


http://reviews.llvm.org/D20654





More information about the llvm-commits mailing list