[PATCH] D20711: [codeview] Improve readability of type record assembly

[Reid Kleckner via llvm-commits]

rnk created this revision.
rnk added a reviewer: majnemer.
rnk added subscribers: llvm-commits, aaboud, amccarth, zturner.

Adds the method MCStreamer::EmitBinaryData, which is usually an alias
for EmitBytes. In the MCAsmStreamer case, it is overridden to emit hex
dump output like this:
        .byte   0x0e, 0x00, 0x08, 0x10
        .byte   0x03, 0x00, 0x00, 0x00
        .byte   0x00, 0x00, 0x00, 0x00
        .byte   0x00, 0x10, 0x00, 0x00

Also, when verbose asm comments are enabled, this patch prints the dump
output for each comment before its record, like this:
        # ArgList (0x1000) {
        #   TypeLeafKind: LF_ARGLIST (0x1201)
        #   NumArgs: 0
        #   Arguments [
        #   ]
        # }
        .byte   0x06, 0x00, 0x01, 0x12
        .byte   0x00, 0x00, 0x00, 0x00

This should make debugging easier and testing more convenient.

http://reviews.llvm.org/D20711

Files:
  include/llvm/DebugInfo/CodeView/MemoryTypeTableBuilder.h
  include/llvm/DebugInfo/CodeView/TypeDumper.h
  include/llvm/MC/MCStreamer.h
  include/llvm/Support/ScopedPrinter.h
  lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
  lib/DebugInfo/CodeView/MemoryTypeTableBuilder.cpp
  lib/MC/MCAsmStreamer.cpp
  lib/MC/MCStreamer.cpp
  test/DebugInfo/COFF/inlining.ll
  tools/llvm-pdbdump/llvm-pdbdump.cpp
  tools/llvm-readobj/COFFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20711.58716.patch
Type: text/x-patch
Size: 13935 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160526/5b0d1204/attachment.bin>