[PATCH] D20456: [CodeGen] Fix problem with X86 byte registers in CriticalAntiDepBreaker

[Mitch Bodart via llvm-commits]

mbodart added inline comments.

================
Comment at: test/CodeGen/X86/pr27681.mir:9-12
@@ +8,6 @@
+  define i32 @main() {
+  entry:
+    ret i32 0
+  }
+
+...
----------------
MatzeB wrote:
> mbodart wrote:
> > Tried that, but llc want' to see a label corresponding to bb.0.entry.
> I did not know it referenced the IR blocks. But then my guess would be that you can rename 'bb.0.entry' to 'bb.0' to break this reference.
Yup, that works.  Will fix.

================
Comment at: test/CodeGen/X86/pr27681.mir:90
@@ +89,2 @@
+
+...
----------------
MatzeB wrote:
> mbodart wrote:
> > Just removing instructions from bb.2 caused the failure to not reproduce.
> > I think, but haven't verified, that having %cl be live out is needed.
> > 
> > I originally had the CHECK-LABEL up near main, but llc chokes on that.
> The problem is probably the different comment characters. Currently `#` is used to introduce comments in yaml but `;` is used for comments inside the code blocks.
Interesting, very picky.  I had tried using #, but I had the CHECK-LABEL line after the name line.  Putting it before the name line works, so I'll do that.


http://reviews.llvm.org/D20456