[PATCH] D20698: [ARM] Transform LDMs into writeback form to save code size

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 13:45:58 PDT 2016


mcrosier added inline comments.

================
Comment at: lib/Target/ARM/ARMLoadStoreOptimizer.cpp:1245
@@ +1244,3 @@
+
+      if (BaseKill && MBB.getParent()->getFunction()->optForMinSize() &&
+          !HighRegsUsed)
----------------
'BaseKill' looks invariant in this code as well, so you could put that in the outer check as well, if I'm not mistaken..

  if (BaseKill && MBB.getParent()->getFunction()->optForMinSize()) {
  
  } else
    return false;


Repository:
  rL LLVM

http://reviews.llvm.org/D20698





More information about the llvm-commits mailing list