[PATCH] D20453: Remove optnone/opt-bisect check from StackColoring

[Paul Robinson via llvm-commits]

probinson added a comment.

Hmmm.  In the optnone case, presumably we're not running that pass that inserts the lifetime markers; if there are no markers, and this pass runs, naively it looks like this would be a no-op pass.  So, from the optnone perspective, this change would not be a problem.

But if you're bisecting, there might be markers, and if the bisection point is between the insertion and this pass, then later on codegen will fail. This change means, if the bisection point is between the insertion and this pass, then this pass runs anyway.

In effect this becomes an always-run pass, and whether it does anything depends on whether the marker-insertion pass runs.  Makes the bisection less ideal, but I guess we can live with that.


================
Comment at: test/Other/opt-bisect-legacy-pass-manager.ll:157
@@ -156,1 +156,3 @@
 }
+
+define void @f4() {
----------------
This wants some commentary, as each hunk of this test is doing something particular and this new hunk isn't doing the same thing as the previous hunk.


Repository:
  rL LLVM

http://reviews.llvm.org/D20453