[PATCH] D20654: [pdb] Try super hard to conserve memory in llvm-pdbdump

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu May 26 11:10:44 PDT 2016


rnk added a comment.

We discussed in person structuring this so we don't need special stream classes to refer to data from the file or from a memory pool on the side.


================
Comment at: include/llvm/DebugInfo/PDB/Raw/ModInfo.h:88-89
@@ -41,2 +87,4 @@
 private:
-  const FileLayout *Layout;
+  codeview::StreamString ModuleName;
+  codeview::StreamString ObjFileName;
+  codeview::StreamObject<FileLayout> Layout;
----------------
Let's try to arrange things so these are just plain StringRefs pointing into the file or optionally a pool on the side.


http://reviews.llvm.org/D20654





More information about the llvm-commits mailing list