[PATCH] D20686: [X86][SSE] Replace (V)PMOVSX and (V)PMOVZX integer extension intrinsics with generic IR (llvm)

[Ahmed Bougacha via llvm-commits]

ab added a subscriber: ab.
ab accepted this revision.
ab added a reviewer: ab.
ab added a comment.
This revision is now accepted and ready to land.

Nice, LGTM!  A few nits unrelated to your change.


================
Comment at: test/CodeGen/X86/avx-intrinsics-x86-upgrade.ll:253
@@ +252,3 @@
+; CHECK:       ## BB#0:
+; CHECK-NEXT:    vpmovzxbd {{.*#+}} xmm0 = xmm0[0],zero,zero,zero,xmm0[1],zero,zero,zero,xmm0[2],zero,zero,zero,xmm0[3],zero,zero,zero
+; CHECK-NEXT:    retl
----------------
Any reason this file isn't an opt test?

================
Comment at: test/CodeGen/X86/avx-intrinsics-x86.ll:4033
@@ -4128,3 +4032,3 @@
 ; AVX512VL-NEXT:    movl {{[0-9]+}}(%esp), %eax
-; AVX512VL-NEXT:    vpaddb LCPI231_0, %ymm0, %ymm0
+; AVX512VL-NEXT:    vpaddb LCPI225_0, %ymm0, %ymm0
 ; AVX512VL-NEXT:    vmovdqu %ymm0, (%eax)
----------------
Gross! I thought the script turned these into {{LCPI.*}} ?

================
Comment at: test/CodeGen/X86/avx2-pmovxrm-intrinsics.ll:1
@@ -1,2 +1,2 @@
 ; RUN: llc < %s -mtriple=x86_64-apple-darwin -mcpu=x86-64 -mattr=+avx2 | FileCheck %s
 
----------------
Drop -intrinsics from the filename?

Also, drop -mcpu? And maybe also update_llc_test_checks

================
Comment at: test/CodeGen/X86/avx2-pmovxrm-intrinsics.ll:3
@@ -2,3 +2,3 @@
 
 define <16 x i16> @test_lvm_x86_avx2_pmovsxbw(<16 x i8>* %a) {
 ; CHECK-LABEL: test_lvm_x86_avx2_pmovsxbw
----------------
lvm -> llvm


Repository:
  rL LLVM

http://reviews.llvm.org/D20686