[PATCH] D20610: [TRE] Slight refactor and cleanup.

[Davide Italiano via llvm-commits]

davide added a comment.

This seems a nice cleanup in preparation for porting to the new PM. Some comments inline.


================
Comment at: lib/Transforms/Scalar/TailRecursionElimination.cpp:58
@@ -58,4 +57,3 @@
 #include "llvm/Analysis/CFG.h"
-#include "llvm/Analysis/CaptureTracking.h"
-#include "llvm/Analysis/InlineCost.h"
+#include "llvm/Analysis/GlobalsModRef.h"
 #include "llvm/Analysis/InstructionSimplify.h"
----------------
Can you split the include-what-you-use patch?

================
Comment at: lib/Transforms/Scalar/TailRecursionElimination.cpp:81
@@ -97,27 +80,3 @@
     void getAnalysisUsage(AnalysisUsage &AU) const override;
-
     bool runOnFunction(Function &F) override;
   };
----------------
Probably runOnFunction() and getAnalyisUsage() can be inlined here.


Repository:
  rL LLVM

http://reviews.llvm.org/D20610