[PATCH] D20653: LICM: Do not sink or hoist assume intrinsic calls.

[Daniel Berlin via llvm-commits]

I'm fine with reverting it if we aren't going to fix it properly ATM.

But of course, for the moment that just means special casing assume in
other places

On Wed, May 25, 2016, 5:13 PM Hal Finkel <hfinkel at anl.gov> wrote:

> hfinkel added a comment.
>
> In http://reviews.llvm.org/D20653#440268, @sanjoy wrote:
>
> > IIUC this is also a correctness fix, right?
> >
> > Since you could have had:
> >
> >   volatile boolean always_false = ...;
> >   for (...)
> >     if (always_false)
> >       assume(false);
> >
> >
> > and hoisting out `assume(false)` to the loop preheader will make the
> loop appear dead.
>
>
> Yes.
>
> I was afraid something like this might happen. I think we need to revert
> r268068 (and the various follow-up fixes). Thoughts?
>
>
> http://reviews.llvm.org/D20653
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160526/ef6d3607/attachment.html>