[PATCH] D20643: Move whole-program virtual call optimization pass after function attribute inference in LTO pipeline.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 14:28:19 PDT 2016


pcc added inline comments.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:590
@@ -585,3 +589,3 @@
   // produce the same result as if we only do promotion here.
   PM.add(createPGOIndirectCallPromotionLegacyPass(true));
 
----------------
mehdi_amini wrote:
> Why is this enable now at O1?
My initial thought was that if the user provided profile information, we should probably use it. Although now that I think about it more, it isn't clear that we can make meaningful use of it with our current O1 pipeline, and in any case, that's orthogonal to this change. Disabled.


http://reviews.llvm.org/D20643





More information about the llvm-commits mailing list