[PATCH] D20642: [codeview] Use comdats for debug info describing comdat functions

[David Majnemer via llvm-commits]

majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:21-22
@@ -20,3 +20,4 @@
 #include "llvm/MC/MCExpr.h"
 #include "llvm/MC/MCSymbol.h"
+#include "llvm/MC/MCSectionCOFF.h"
 #include "llvm/Support/COFF.h"
----------------
Please sort these.

================
Comment at: lib/CodeGen/AsmPrinter/CodeViewDebug.h:107
@@ +106,3 @@
+  /// This set tracks which sections we've already opened.
+  SmallPtrSet<MCSectionCOFF *, 4> ComdatDebugSections;
+
----------------
Hmm, will this really be small for most TUs?


http://reviews.llvm.org/D20642