[PATCH] D20558: [LibFuzzer] Start cleaning up the CMakeLists.txt files.

[Dan Liew via llvm-commits]

delcypher added a comment.

In http://reviews.llvm.org/D20558#439779, @kcc wrote:

> This is rather confusing. I stopped understanding why you are doing this and it looks like you are trying to solve several problems at once.
>
> try to
>
> - split this patch into several, each patch solving just one problem  (if possible)


Although I can split a few things out doing so is going to be a pain because that means I am going has separate reviews going that are dependent on each other and I'm not sure if that really works in fabricator.

> - make the cmake files smaller, not bigger


That should not be a hard rule. If a change makes something clearer by adding a few lines I consider that to be the right trade-off

> - avoid non-actionable FIXMEs


All the FIXMEs are actionable.

I'm not sure where you want to go from here. I can split this patch up into to three bits but I'm not convinced it will possible to review them in phabricator because the changes are dependent on each other.


http://reviews.llvm.org/D20558