[PATCH] D20629: Port the strip-invalid-debuginfo logic to the legacy verifier pass, too.

[Adrian Prantl via llvm-commits]

aprantl added a comment.

In http://reviews.llvm.org/D20629#439835, @joker.eph wrote:

> > Since r268966 the modern Verifier pass defaults to stripping invalid debug info in nonasserts builds.  This patch ports this behavior back to the legacy Verifier pass as well.
>
>
> This sentence makes me expect a difference between release and assert builds, and I don't spot it in this patch.


The difference is this assert:

  assert(!V.hasBrokenDebugInfo() && "Module contains invalid debug info");


================
Comment at: lib/IR/Verifier.cpp:4475
@@ -4475,3 +4474,3 @@
     initializeVerifierLegacyPassPass(*PassRegistry::getPassRegistry());
   }
 
----------------
joker.eph wrote:
> It is not clear to me why `new VerifierLegacyPass()` has a different behavior with respect to debug info compared to `new VerifierLegacyPass(true)` or  `new VerifierLegacyPass(false)` (these last two will have the same behavior in face of debug info.
Good catch, they probably shouldn't.


http://reviews.llvm.org/D20629