[PATCH] D20559: [ThinLTO/gold] Handle bitcode archives

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In http://reviews.llvm.org/D20559#439478, @tejohnson wrote:

> In http://reviews.llvm.org/D20559#439159, @tejohnson wrote:
>
> > I am first tracking down a runtime error in the llvm-tblgen binary built using this patch with latest clang+llvm sources (it seems related to ThinLTO since it goes away when I disable some amount of importing, but I wasn't getting this with my fixes on a slightly older revision, so I don't think it is caused by this patch directly)
>
>
> Confirmed not due to this patch - I can repro at head without this patch, working around it by linking llvm-tblgen with the archive library constituent .o files directly. While I track that down (possibly just exposed by ThinLTO's larger optimization scope) I will see if I can figure out a way to work around it here to do more testing of this patch.


I was able to test this and get a successful bootstrap of clang with ThinLTO and gold by temporarily reducing the importing threshold enough to avoid the apparent bug.

> Can you please also see if this works if you pass --no-map-whole-files to gold?


Confirmed this works, as well as --no-keep-files-mapped.


http://reviews.llvm.org/D20559