[PATCH] D20616: Fix Function Attributes computation for llvm.assume

[David Majnemer via llvm-commits]

majnemer added a subscriber: majnemer.
majnemer requested changes to this revision.
majnemer added a reviewer: majnemer.
This revision now requires changes to proceed.

================
Comment at: lib/Transforms/IPO/FunctionAttrs.cpp:208-211
@@ -207,1 +207,6 @@
 
+    if (F->getIntrinsicID() == Intrinsic::assume)
+      // don't change attributes of the assume intrinsic, 
+      // so that later on, it is not thrown away by other optimizations
+      continue;
+
----------------
Sentences start with a capital letter and a period.

================
Comment at: test/Transforms/FunctionAttrs/assume.ll:2
@@ +1,3 @@
+; RUN: opt -functionattrs -S < %s | FileCheck %s
+; RUN: opt -functionattrs -instcombine -S < %s | FileCheck %s -check-prefix=ASSUME
+;
----------------
Why do we need to run InstCombine to test this change?


http://reviews.llvm.org/D20616