[zorg] r270539 - Enable modules selfhosting builds with libstdc++, too.

Vassil Vassilev via llvm-commits llvm-commits at lists.llvm.org
Wed May 25 05:19:28 PDT 2016


Hi Galina,
   I am attaching a patch that I believe fixes the issue. Could you 
review it please (I don't know how to test it).
Many thanks,
Vassil
On 25/05/16 11:36, Vassil Vassilev wrote:
> This broke our modules slaves. I am working on a fix. Sorry for the 
> inconvenience!
> -- Vassil
> On 24/05/16 11:23, Vassil Vassilev via llvm-commits wrote:
>> Author: vvassilev
>> Date: Tue May 24 04:22:58 2016
>> New Revision: 270539
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=270539&view=rev
>> Log:
>> Enable modules selfhosting builds with libstdc++, too.
>>
>> If a modulemap is not present (in the case of libstdc++), we will end 
>> up with
>> duplicate entities in the modules. This will help us stress test the 
>> module
>> merging and discover potential bugs.
>>
>> Modified:
>>      zorg/trunk/zorg/buildbot/builders/ClangBuilder.py
>>
>> Modified: zorg/trunk/zorg/buildbot/builders/ClangBuilder.py
>> URL: 
>> http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/ClangBuilder.py?rev=270539&r1=270538&r2=270539&view=diff
>> ============================================================================== 
>>
>> --- zorg/trunk/zorg/buildbot/builders/ClangBuilder.py (original)
>> +++ zorg/trunk/zorg/buildbot/builders/ClangBuilder.py Tue May 24 
>> 04:22:58 2016
>> @@ -281,8 +281,6 @@ def getClangBuildFactory(
>>       cxx_flags = ''
>>       extra_args = []
>>       if modules:
>> -        # Modules requires libc++ for now (we don't have a module 
>> map for libstdc++ yet).
>> -        cxx_flags += '-stdlib=libc++'
>>           extra_args = ['-DLLVM_ENABLE_MODULES=1']
>>         f.addStep(ShellCommand(name='cmake',
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: zorg_fix.diff
Type: text/x-patch
Size: 3785 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160525/6f1f3296/attachment.bin>


More information about the llvm-commits mailing list