[PATCH] D20337: [MC] Support symbolic expressions in assembly directives

[Nirav Dave via llvm-commits]

niravd added inline comments.

================
Comment at: lib/MC/MCAsmStreamer.cpp:828
@@ +827,3 @@
+  MCStreamer::emitFill(NumBytes, FillValue);
+}
+
----------------
I believe it still is. Consider the case where the symbolic expression emitted for NumBytes is eventually evaluated to a non-positive number or is invalid? Errors in the compilation of the output assembly would point to location in the output asm file not the original as it should. 




Repository:
  rL LLVM

http://reviews.llvm.org/D20337