[PATCH] D20590: [esan|cfrag] Add struct infomation printing for the cfrag tool.

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 15:01:15 PDT 2016


aizatsky added inline comments.

================
Comment at: lib/esan/cache_frag.cpp:38
@@ -25,1 +37,3 @@
 
+static void printStructInfo(CacheFragTy *CacheFrag) {
+  // We print StructInfo for debugging purpose.
----------------
Not sure about this, but maybe add "print" member methods to structs?

================
Comment at: lib/esan/cache_frag.cpp:40
@@ +39,3 @@
+  // We print StructInfo for debugging purpose.
+  if ((uptr)Verbosity() >= 3) {
+    for (u32 i = 0; i < CacheFrag->NumOfStructs; ++i) {
----------------
why (uptr) casts?


http://reviews.llvm.org/D20590





More information about the llvm-commits mailing list