[PATCH] D20483: [esan] EfficiencySanitizer working set tool fastpath

[Mike Aizatsky via llvm-commits]

aizatsky added inline comments.

================
Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:412
@@ +411,3 @@
+  if (!(TypeSize == 8 ||
+        // Ensure the shadow doesn't straddle a cache line
+        (Alignment % (TypeSize / 8)) == 0))
----------------
I'm sorry but I (and people in my cube) don't really understand what "straddle a cache line" mean. Could you rewrite the comment to explain the reasoning better? What is the plan for TypeSize != 8? Slow path?

================
Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:414
@@ +413,3 @@
+        (Alignment % (TypeSize / 8)) == 0))
+    return false;
+
----------------
NumFastpaths is not incremented though.


http://reviews.llvm.org/D20483