[PATCH] D20592: Add FIXMEs to all derived classes of std::error_category.

[Lang Hames via llvm-commits]

lhames added a subscriber: lhames.
lhames added a comment.

I like the idea of making it clearer that we're moving to Error as the standard error handling mechanism, but this could generate confusion because (at least the way I read them) these FIXMEs suggest that we could remove the error categories piecemeal, which isn't the case: To maintain compatibility with std::error_code (via the errorToErrorCode and expectedToErrorOr methods) we require that all error types be convertible to an equivalent error_code. We can't remove that requirement until all LLVM code has moved over to Error.


http://reviews.llvm.org/D20592