[PATCH] D20559: [ThinLTO/gold] Handle bitcode archives

[Peter Collingbourne via llvm-commits]

pcc added a comment.

Thanks for discovering that issue with the gold plugin API, that's nasty. It reminds me that I'll probably have to be more careful with memory ownership in http://reviews.llvm.org/D20268.

Can you please also see if this works if you pass `--no-map-whole-files` to gold?


================
Comment at: tools/gold/gold-plugin.cpp:522
@@ -506,1 +521,3 @@
+  if (file->offset)
+    cf.name += "." + std::to_string(file->offset);
 
----------------
Nit: maybe `"/" + std::to_string(file->offset)` to avoid possibility of collisions with real files?


http://reviews.llvm.org/D20559