[PATCH] D20571: [BPF] Remove exit-on-error flag in test (PR27767)

Diana Picus via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 09:35:54 PDT 2016


rovka created this revision.
rovka added a reviewer: ast.
rovka added subscribers: llvm-commits, rengolin.

The exit-on-error flag is needed to avoid an assert where llvm::SelectionDAGISel::LowerArguments doesn't create enough arguments. Fill up with UNDEF to reach the right number of args.

Fixes PR27767.

http://reviews.llvm.org/D20571

Files:
  lib/Target/BPF/BPFISelLowering.cpp
  test/CodeGen/BPF/many_args2.ll

Index: test/CodeGen/BPF/many_args2.ll
===================================================================
--- test/CodeGen/BPF/many_args2.ll
+++ test/CodeGen/BPF/many_args2.ll
@@ -1,4 +1,4 @@
-; RUN: not llc -march=bpf -exit-on-error < %s 2> %t1
+; RUN: not llc -march=bpf < %s 2> %t1
 ; RUN: FileCheck %s < %t1
 ; CHECK: too many args
 
Index: lib/Target/BPF/BPFISelLowering.cpp
===================================================================
--- lib/Target/BPF/BPFISelLowering.cpp
+++ lib/Target/BPF/BPFISelLowering.cpp
@@ -199,6 +199,7 @@
       }
     } else {
       fail(DL, DAG, "defined with too many args");
+      InVals.push_back(DAG.getUNDEF(MVT::Other));
     }
   }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20571.58249.patch
Type: text/x-patch
Size: 686 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160524/bfaee77a/attachment.bin>


More information about the llvm-commits mailing list