[PATCH] D20058: [SCEV] No-wrap flags are not propagated when folding "{S, +, X}+T ==> {S+T, +, X}"

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 09:35:08 PDT 2016


sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm with nits

Let me know if you need me to check this in for you.


================
Comment at: test/Analysis/ScalarEvolution/nsw.ll:181
@@ +180,3 @@
+
+; This test checks if no-wrap flags are propagated when folding {S,+,X}+T ==> {S+T,+,X} (D20058)
+; CHECK: %idxprom
----------------
Nit: you don't need to specify `D20058` here.  Also use a `CHECK-LABEL: <function name>` like in the previous tests.

================
Comment at: test/Analysis/ScalarEvolution/nsw.ll:201
@@ +200,2 @@
+  ret void
+}
----------------
Add newline at end of file?


Repository:
  rL LLVM

http://reviews.llvm.org/D20058





More information about the llvm-commits mailing list