[PATCH] D20290: [ThinLTO] Change ODR resolution and internalization to be index-based

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue May 24 09:13:26 PDT 2016


joker.eph added inline comments.

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:339
@@ -344,2 +338,3 @@
+  }
 }
 
----------------
Yes in ld64 and regular monolithic LTO, we are internalizing linkonce_ODR if they are not exported.
Can weak functions defined in the main binary be overriden at runtime?
It may be a platform specific question...



http://reviews.llvm.org/D20290





More information about the llvm-commits mailing list