[PATCH] D20425: [sanitizer] Don't use -fomit-frame-pointer in COMPILER_RT_DEBUG=On builds

[Filipe Cabecinhas via llvm-commits]

filcab added a comment.

I've seen them on OS X. Example:

FAIL: AddressSanitizer-x86_64-darwin ::
TestCases/malloc_context_size.cc (1127 of 1216)

- TEST 'AddressSanitizer-x86_64-darwin ::

TestCases/malloc_context_size.cc' FAILED ********************

Script:
-------

/Users/filcab/work/llvm-cmake/./bin/clang --driver-mode=g++
-fsanitize=address -mno-omit-leaf-frame-pointer
-fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only
-arch x86_64 -O0
/Users/filcab/work/llvm/projects/compiler-rt/test/asan/TestCases/malloc_context_size.cc
-o /Users/filcab/work/llvm-cmake/projects/compiler-rt/test/asan/X86_64DarwinConfig/TestCases/Output/malloc_context_size.cc.tmp
env ASAN_OPTIONS=abort_on_error=0:log_to_syslog=0:malloc_context_size=0:fast_unwind_on_malloc=0
not  /Users/filcab/work/llvm-cmake/projects/compiler-rt/test/asan/X86_64DarwinConfig/TestCases/Output/malloc_context_size.cc.tmp
2>&1 | FileCheck
/Users/filcab/work/llvm/projects/compiler-rt/test/asan/TestCases/malloc_context_size.cc
env ASAN_OPTIONS=abort_on_error=0:log_to_syslog=0:malloc_context_size=0:fast_unwind_on_malloc=1
not  /Users/filcab/work/llvm-cmake/projects/compiler-rt/test/asan/X86_64DarwinConfig/TestCases/Output/malloc_context_size.cc.tmp
2>&1 | FileCheck
/Users/filcab/work/llvm/projects/compiler-rt/test/asan/TestCases/malloc_context_size.cc
env ASAN_OPTIONS=abort_on_error=0:log_to_syslog=0:malloc_context_size=1:fast_unwind_on_malloc=0
not  /Users/filcab/work/llvm-cmake/projects/compiler-rt/test/asan/X86_64DarwinConfig/TestCases/Output/malloc_context_size.cc.tmp
2>&1 | FileCheck
/Users/filcab/work/llvm/projects/compiler-rt/test/asan/TestCases/malloc_context_size.cc
env ASAN_OPTIONS=abort_on_error=0:log_to_syslog=0:malloc_context_size=1:fast_unwind_on_malloc=1
not  /Users/filcab/work/llvm-cmake/projects/compiler-rt/test/asan/X86_64DarwinConfig/TestCases/Output/malloc_context_size.cc.tmp
2>&1 | FileCheck
/Users/filcab/work/llvm/projects/compiler-rt/test/asan/TestCases/malloc_context_size.cc
env ASAN_OPTIONS=abort_on_error=0:log_to_syslog=0:malloc_context_size=2
not  /Users/filcab/work/llvm-cmake/projects/compiler-rt/test/asan/X86_64DarwinConfig/TestCases/Output/malloc_context_size.cc.tmp
2>&1 | FileCheck
/Users/filcab/work/llvm/projects/compiler-rt/test/asan/TestCases/malloc_context_size.cc

--check-prefix=TWO
------------------

Exit Code: 1

Command Output (stderr):
------------------------

/Users/filcab/work/llvm/projects/compiler-rt/test/asan/TestCases/malloc_context_size.cc:14:17:
error: expected string not found in input
 // CHECK-NEXT: #0 0x{{.*}} in {{operator delete( )?\[\]|wrap__ZdaPv}}

  ^

<stdin>:10:2: note: scanning from here
 #0 0x102993eaf in wrap_free
(/Users/filcab/work/llvm-cmake/lib/clang/3.9.0/lib/darwin/libclang_rt.asan_osx_dynamic.dylib+0x4beaf)
 ^
<stdin>:24:30: note: possible intended match here
 0x1c0600001c00: 00 fa fa fa 00 00 00 fa fa fa 00 00 00 fa fa fa

  ^

-

********************

Testing Time: 596.75s

********************

Failing Tests (4):

  AddressSanitizer-i386-darwin :: TestCases/large_func_test.cc
  AddressSanitizer-i386-darwin :: TestCases/malloc_context_size.cc
  AddressSanitizer-x86_64-darwin :: TestCases/large_func_test.cc
  AddressSanitizer-x86_64-darwin :: TestCases/malloc_context_size.cc

large_func_test.cc has a similar failure, but it's trying to match
.*_Zna.* and gets wrap_malloc.

Thank you,

  Filipe


Repository:
  rL LLVM

http://reviews.llvm.org/D20425