[PATCH] D20466: [MC/ELF] - Fixed incorrect compression.s test

[Rafael Espíndola via llvm-commits]

LGTM, please commit.

On 24 May 2016 at 09:33, George Rimar <grimar at accesssoftek.com> wrote:
> grimar updated this revision to Diff 58229.
> grimar added a comment.
>
> - Addressed review comments. Patch only perform change to check comression roundtrip and nothing more (+few comments).
>
>
> http://reviews.llvm.org/D20466
>
> Files:
>   ELF/compression.s
>
> Index: ELF/compression.s
> ===================================================================
> --- ELF/compression.s
> +++ ELF/compression.s
> @@ -1,30 +1,31 @@
>  // RUN: llvm-mc -filetype=obj -compress-debug-sections -triple x86_64-pc-linux-gnu < %s -o %t
>  // RUN: llvm-objdump -s %t | FileCheck %s
> -// RUN: llvm-dwarfdump -debug-dump=info %t | FileCheck --check-prefix=INFO %s
> +// RUN: llvm-dwarfdump -debug-dump=str %t | FileCheck --check-prefix=STR %s
>  // RUN: llvm-mc -filetype=obj -compress-debug-sections -triple i386-pc-linux-gnu < %s \
>  // RUN:     | llvm-readobj -symbols - | FileCheck --check-prefix=386-SYMBOLS %s
>
>  // REQUIRES: zlib
>
> -// CHECK: Contents of section .zdebug_line:
> -// Check for the 'ZLIB' file magic at the start of the section only
> -// CHECK-NEXT: ZLIB
> -// CHECK-NOT: ZLIB
> -
>  // Don't compress small sections, such as this simple debug_abbrev example
>  // CHECK: Contents of section .debug_abbrev:
>  // CHECK-NOT: ZLIB
>  // CHECK-NOT: Contents of
>
>  // CHECK: Contents of section .debug_info:
>
> +// CHECK: Contents of section .zdebug_str:
> +// Check for the 'ZLIB' file magic at the start of the section only
> +// CHECK-NEXT: ZLIB
> +// CHECK-NOT: ZLIB
> +
>  // FIXME: Handle compressing alignment fragments to support compressing debug_frame
>  // CHECK: Contents of section .debug_frame:
>  // CHECK-NOT: ZLIB
>  // CHECK: Contents of
>
> -// Decompress one valid dwarf section just to check that this roundtrips
> -// INFO: 0x00000000: Compile Unit: length = 0x0000000c version = 0x0004 abbr_offset = 0x0000 addr_size = 0x08 (next unit at 0x00000010)
> +// Decompress one valid dwarf section just to check that this roundtrips,
> +// we use .zdebug_str section for that
> +// STR: perfectly compressable data sample *****************************************
>
>  // In x86 32 bit named symbols are used for temporary symbols in merge
>  // sections, so make sure we handle symbols inside compressed sections
> @@ -74,6 +75,9 @@
>         .cfi_endproc
>         .cfi_sections .debug_frame
>
> +# Below is the section we will use to check that after compression with llvm-mc,
> +# llvm-dwarfdump tool will be able to decompress data back and dump it. Data sample
> +# should be compressable enough, so it is filled with some amount of equal symbols at the end
>         .section        .debug_str,"MS", at progbits,1
>  .Linfo_string0:
> -        .asciz  "compress this                                    "
> +        .asciz  "perfectly compressable data sample *****************************************"
>
>