[PATCH] D20545: [codeview] Dump symbol record details from llvm-pdbdump

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 17:23:38 PDT 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: tools/llvm-pdbdump/llvm-pdbdump.cpp:405-409
@@ +404,7 @@
+  } else if (opts::DumpModuleSyms) {
+    // Even if the user doesn't want to dump type records, we still need to
+    // iterate them in
+    // order to build the list of types so that we can print them when dumping
+    // module symbols.
+    // So when they want to dump symbols but not types, use a null output
+    // stream.
----------------
You want to fix the position of newlines.


http://reviews.llvm.org/D20545





More information about the llvm-commits mailing list