[PATCH] D20541: [esan|cfrag]: Add createCacheFragGV.

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 15:00:00 PDT 2016


vitalybuka added inline comments.

================
Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:109
@@ +108,3 @@
+  // Static help routines:
+  static GlobalVariable *createPrivateGlobalForString(
+      Module &M, StringRef Str, bool AllowMerging);
----------------
This function does nothing with internals of EfficiencySanitizer so why not to keep it 
as regular function outside of the class?



http://reviews.llvm.org/D20541





More information about the llvm-commits mailing list