[PATCH] D20273: [llvm-readobj] - Teach readobj to recognize SHF_COMPRESSED flag.
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Mon May 23 02:02:40 PDT 2016
davide added a comment.
In http://reviews.llvm.org/D20273#436565, @grimar wrote:
> So my opinion that sometimes it is profitably to use llvm-mc, but sometimes - not.
> (Just in case, are you aware that zlib on windows is broken >= 2 years ? https://llvm.org/bugs/show_bug.cgi?id=19403, so use of llvm-mc for this test would just skip
> running testcases on whole windows world). That is what I thinkg a good example of excessive dependency on llvm-mc.
I respectfully disagree. There's no correlation between zlib broken on windows and llvm-mc.
If zlib is broken on windows, we should spend time fixing it, not silently ignoring the problem.
In http://reviews.llvm.org/D20273#436566, @davide wrote:
> In http://reviews.llvm.org/D20273#436565, @grimar wrote:
>
> > So my opinion that sometimes it is profitably to use llvm-mc, but sometimes - not.
> > (Just in case, are you aware that zlib on windows is broken >= 2 years ? https://llvm.org/bugs/show_bug.cgi?id=19403, so use of llvm-mc for this test would just skip
> > running testcases on whole windows world). That is what I thinkg a good example of excessive dependency on llvm-mc.
>
>
> I respectfully disagree. There's no correlation between zlib broken on windows and llvm-mc.
> If zlib is broken on windows, we should spend time fixing it, not silently ignoring the problem.
I went ahead and reassigned PR19403 to myself.
Repository:
rL LLVM
http://reviews.llvm.org/D20273
More information about the llvm-commits
mailing list