[PATCH] D20518: [X86][RTM] _xabort() should not have "noreturn" attribute

Asaf Badouh via llvm-commits llvm-commits at lists.llvm.org
Mon May 23 00:18:39 PDT 2016


AsafBadouh created this revision.
AsafBadouh added reviewers: aaboud, DavidKreitzer, igorb.
AsafBadouh added a subscriber: llvm-commits.
AsafBadouh set the repository for this revision to rL LLVM.

calling to _xabort() outside RTM execution section should be "nop".

Simplify CFG check call with noreturn attribute and mark the rest of the block as "unreachable".

Repository:
  rL LLVM

http://reviews.llvm.org/D20518

Files:
  include/llvm/IR/IntrinsicsX86.td

Index: include/llvm/IR/IntrinsicsX86.td
===================================================================
--- include/llvm/IR/IntrinsicsX86.td
+++ include/llvm/IR/IntrinsicsX86.td
@@ -4995,7 +4995,7 @@
   def int_x86_xend : GCCBuiltin<"__builtin_ia32_xend">,
               Intrinsic<[], [], []>;
   def int_x86_xabort : GCCBuiltin<"__builtin_ia32_xabort">,
-              Intrinsic<[], [llvm_i8_ty], [IntrNoReturn]>;
+              Intrinsic<[], [llvm_i8_ty], []>;
   def int_x86_xtest : GCCBuiltin<"__builtin_ia32_xtest">,
               Intrinsic<[llvm_i32_ty], [], []>;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D20518.58073.patch
Type: text/x-patch
Size: 587 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160523/1617128c/attachment.bin>


More information about the llvm-commits mailing list