[PATCH] D20425: [sanitizer] Don't use -fomit-frame-pointer in COMPILER_RT_DEBUG=On builds

[Filipe Cabecinhas via llvm-commits]

Fair enough, at most we'd know the text works on a given version of Xcode
but wouldn't be able to guarantee to make it work all the time.

I've never seen this problem when trying on OS X, though. What I've seen
are problems around wrap_free and too much data for a given section on tsan.

Thank you,

 Filipe



On Sunday, 22 May 2016, Kuba Brecka <kuba.brecka at gmail.com> wrote:

> kubabrecka added a comment.
>
> In http://reviews.llvm.org/D20425#436476, @filcab wrote:
>
> > You mean in production, right?
> >  Please add a test that shows the problem. If this problem happens we
> want
> >  to protect against it being reintroduced in the future.
> >
> > Thank you,
> >
> >   Filipe
>
>
> No, I'm not talking about production.  `COMPILER_RT_DEBUG=On` is not used
> in production.
>
> Adding a testcase for this is very problematic.  I'm talking about
> external (non-LLVM) tools having issues taking correct backtraces when
> `-fomit-frame-pointers` is used.  This problem exists both for `-O0`
> (development) and `-O3` (production) builds of compiler-rt.  This was
> already discussed a long time ago and the status quo is that
> `-fomit-frame-pointers` needs to be used for performance reasons, even when
> it makes debugging harder and it can break external tools.
>
> This patch changes debug/development builds only, where performance
> doesn't matter that much, and any optimizations are usually undesirable.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D20425
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160522/95f7d8e2/attachment.html>