[PATCH] D20425: [sanitizer] Don't use -fomit-frame-pointer in COMPILER_RT_DEBUG=On builds

[Filipe Cabecinhas via llvm-commits]

You mean in production, right?
Please add a test that shows the problem. If this problem happens we want
to protect against it being reintroduced in the future.

Thank you,

 Filipe

On Sunday, 22 May 2016, Phabricator <reviews at reviews.llvm.org> wrote:

> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL270376: [sanitizer] Don't use -fomit-frame-pointer in
> COMPILER_RT_DEBUG=On builds (authored by kuba.brecka).
>
> Changed prior to commit:
>   http://reviews.llvm.org/D20425?vs=57769&id=58064#toc
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D20425
>
> Files:
>   compiler-rt/trunk/CMakeLists.txt
>
> Index: compiler-rt/trunk/CMakeLists.txt
> ===================================================================
> --- compiler-rt/trunk/CMakeLists.txt
> +++ compiler-rt/trunk/CMakeLists.txt
> @@ -174,7 +174,9 @@
>  append_list_if(COMPILER_RT_HAS_FPIC_FLAG -fPIC SANITIZER_COMMON_CFLAGS)
>  append_list_if(COMPILER_RT_HAS_FNO_BUILTIN_FLAG -fno-builtin
> SANITIZER_COMMON_CFLAGS)
>  append_list_if(COMPILER_RT_HAS_FNO_EXCEPTIONS_FLAG -fno-exceptions
> SANITIZER_COMMON_CFLAGS)
> -append_list_if(COMPILER_RT_HAS_FOMIT_FRAME_POINTER_FLAG
> -fomit-frame-pointer SANITIZER_COMMON_CFLAGS)
> +if(NOT COMPILER_RT_DEBUG)
> +  append_list_if(COMPILER_RT_HAS_FOMIT_FRAME_POINTER_FLAG
> -fomit-frame-pointer SANITIZER_COMMON_CFLAGS)
> +endif()
>  append_list_if(COMPILER_RT_HAS_FUNWIND_TABLES_FLAG -funwind-tables
> SANITIZER_COMMON_CFLAGS)
>  append_list_if(COMPILER_RT_HAS_FNO_STACK_PROTECTOR_FLAG
> -fno-stack-protector SANITIZER_COMMON_CFLAGS)
>  append_list_if(COMPILER_RT_HAS_FNO_SANITIZE_SAFE_STACK_FLAG
> -fno-sanitize=safe-stack SANITIZER_COMMON_CFLAGS)
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160522/f5b6c4ac/attachment.html>