[PATCH] D20105: Implement verbose mode in FlieCheck and Lit to capture whole stdin.

[NAKAMURA Takumi via llvm-commits]

chapuni added a comment.

Thanks @filcab.


================
Comment at: llvm/utils/FileCheck/FileCheck.cpp:1310
@@ +1309,3 @@
+  // Override default value of Verbose
+  if (auto p = std::getenv("LLVM_FILECHECK")) {
+    if (StringRef(p) == "-verbose")
----------------
filcab wrote:
> This should be `LLVM_FILECHECK_OPTIONS` or `LLVM_FILECHECK_EXTRA_ARGS` or something.
I prefer LLVM_FILECHECK_OPTIONS. Thanks.

================
Comment at: llvm/utils/FileCheck/FileCheck.cpp:1356
@@ -1344,1 +1355,3 @@
   StringRef Buffer = F->getBuffer();
+  if (Verbose) {
+    errs() << "================\nCommand line:";
----------------
filcab wrote:
> I'd prefer to only print out the whole buffer in case we fail.
I think we could catch successful cases, for example, to compare logs between +Asserts and -Asserts.

Shall we split verbose level, or add another option?

================
Comment at: llvm/utils/lit/lit/TestingConfig.py:32
@@ +31,3 @@
+        if extra_pass_vars:
+            pass_vars.extend(extra_pass_vars.split(':'))
+
----------------
filcab wrote:
> When you propose this, please split this to another commit.
> 
I see. I'll propose this individually.
It'd make "LIT_PRESERVES_TMP" generalized.


Repository:
  rL LLVM

http://reviews.llvm.org/D20105