[PATCH] D20480: pdbdump: print out symbol names referred by publics stream.

[Zachary Turner via llvm-commits]

I was going to comment on that, but this code will go away once I finish
the work on the symbol visitor and start using libcodeview from here.

On Fri, May 20, 2016 at 4:12 PM Reid Kleckner <rnk at google.com> wrote:

> rnk added a subscriber: rnk.
>
> ================
> Comment at: llvm/trunk/lib/DebugInfo/PDB/Raw/SymbolStream.cpp:38
> @@ +37,3 @@
> +  ulittle16_t seg;
> +  char name[1];
> +};
> ----------------
> In the future, please don't use these kind of flexible array members, they
> are how you get buffer overruns when the strings are not null terminated.
> Look at how we are deserializing codeview types instead.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D20480
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160520/b9ad1cec/attachment.html>