[PATCH] D20480: pdbdump: print out symbol names referred by publics stream.

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 15:43:55 PDT 2016


majnemer added a subscriber: majnemer.

================
Comment at: lib/DebugInfo/PDB/Raw/SymbolStream.cpp:57
@@ +56,3 @@
+
+static StringRef makeStringRef(char *p) { return {p, strlen(p)}; }
+
----------------
Why not make this `const char *` ?  Then you could use the implicit constructor to make a `StringRef`.

Also, variable names should be capitalized.


Repository:
  rL LLVM

http://reviews.llvm.org/D20480





More information about the llvm-commits mailing list