[llvm] r269969 - When looking for a spill slot in reg scavenger, find one that matches RC

Krzysztof Parzyszek via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 11:48:24 PDT 2016


On 5/20/2016 1:41 PM, Quentin Colombet wrote:
> My understanding is that for assert builds it will always call abort, so this is an equivalent of assert(false && “…”);
> But we shouldn’t expect more.

Yes, I wasn't really clear.

assert is known to have no effect with NDEBUG. llvm_unreachable, on the 
other hand, will have an unpredictable effect without the benefit of 
presenting the user with any additional information.

I think we should have something like abort("..."), which will do 
exactly that, with the message, regardless of build type.

-Krzysztof


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, 
hosted by The Linux Foundation


More information about the llvm-commits mailing list