[PATCH] D20462: Functions with differing phis should not be merged.

Mark Lacey via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 11:15:25 PDT 2016


rudkx added inline comments.

================
Comment at: test/Transforms/MergeFunc/phi-check-blocks.ll:2
@@ +1,3 @@
+; REQUIRES: asserts
+; RUN: opt < %s -mergefunc -stats -disable-output 2>&1 | not grep "functions merged"
+
----------------
qcolombet wrote:
> Instead of relying on the debug output I guess it would be possible to check that we still have both functions.
> I.e., I would:
> - Get rid of the REQUIRES line
> - Use FileCheck instead of grep
I had originally written the test that way but then noticed that some of the other tests were doing this.

I'll go ahead and change it back.


http://reviews.llvm.org/D20462





More information about the llvm-commits mailing list