[llvm] r269969 - When looking for a spill slot in reg scavenger, find one that matches RC

Benjamin Kramer via llvm-commits llvm-commits at lists.llvm.org
Fri May 20 09:01:44 PDT 2016


report_fatal_error produces user-visible errors, I don't think
including stack traces there is in any way helpful and will only cause
confusion. If a compiler dev doesn't like using a debugger they can
still grep for the error message and quickly find where it's coming
from ...

On Fri, May 20, 2016 at 5:51 PM, Krzysztof Parzyszek
<kparzysz at codeaurora.org> wrote:
> On 5/20/2016 10:43 AM, Benjamin Kramer wrote:
>>
>> You can
>> easily get a stack trace from a debugger, no need to use
>> llvm_unreachable for that.
>
>
> That forces people to use debuggers, which I really don't like.
>
> Maybe printing the stack trace from report_fatal_error (when assertions are
> enabled) would be an option?
>
> -Krzysztof
>
>
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
> The Linux Foundation


More information about the llvm-commits mailing list