[PATCH] D20461: [LibFuzzer] Fix sending SIGALRM to main thread under Mac OSX
Kostya Serebryany via llvm-commits
llvm-commits at lists.llvm.org
Thu May 19 22:50:24 PDT 2016
kcc added a comment.
In http://reviews.llvm.org/D20461#435255, @delcypher wrote:
> @kcc : Just to note I think you already have an implicit pthreads dependency.
Very likely. But it's more like I want to stay away from including pthread.h, if possible.
And also, the current way of dying on OOMs is less portable than just dying inside the getrusage thread.
> The CMakeLists.txt file seems to link
> against it also (side note: why are the flags only being set for the CMake build type being RELEASE?).
For no good reason, feel free to fix that.
> I didn't need to pass `-lpthread` when building (I'm building independently of LLVM's CMake build system) on my system. I suspect that `std::thread` might already be using pthreads internally.
Note that the majority of users use libFuzzer outside of the llvm build system,
will they need to add -lphtread to their build rules?
http://reviews.llvm.org/D20461
More information about the llvm-commits
mailing list